Add minimal regression test for issue #552#1066
Closed
felixweinberger wants to merge 1 commit intomainfrom
Closed
Conversation
This commit adds a minimal test for the Windows hanging issue (#552) where MCP client initialization would hang indefinitely on Windows 11. The test verifies that a simple Python subprocess can initialize without hanging, which would fail with the buggy Windows-specific process creation code but succeeds with the generic anyio.open_process implementation. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a minimal, focused regression test for issue #552 where MCP client initialization would hang indefinitely on Windows 11.
Context
Issue #552 reports that Windows-specific process creation code in
win32.pycauses the client to hang during initialization. The fix involves using the genericanyio.open_processfor all platforms instead of custom Windows-specific code.What This Test Does
The test verifies that stdio_client initialization completes successfully on Windows without hanging by:
initializerequestTest Plan
🤖 Generated with Claude Code